Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-166012: [CCD - Suggested Cards] Enable ABM text under price #3520

Merged
merged 6 commits into from
Jan 29, 2025

Conversation

Axelcureno
Copy link
Member

@Axelcureno Axelcureno commented Jan 21, 2025

Allows authors to include the legend "Annual, paid monthly" next to the price in CCD suggested cards as part of a legal requirement.

Screenshot 2025-01-21 at 3 04 04 PM Screenshot 2025-01-21 at 3 07 00 PM

Resolves: MWPW-166012

Mas link: https://main--mas--adobecom.hlx.page/studio.html?milolibs=MWPW-166012--milo--adobecom#path=drafts

Test URLs:

Copy link
Contributor

aem-code-sync bot commented Jan 21, 2025

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link
Contributor

aem-code-sync bot commented Jan 21, 2025

Page Scores Audits Google
📱 /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.48%. Comparing base (03e7505) to head (c5fc81f).
Report is 4 commits behind head on stage.

Additional details and impacted files
@@           Coverage Diff           @@
##            stage    #3520   +/-   ##
=======================================
  Coverage   96.48%   96.48%           
=======================================
  Files         260      260           
  Lines       60808    60812    +4     
=======================================
+ Hits        58670    58675    +5     
+ Misses       2138     2137    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Roycethan
Copy link

Roycethan commented Jan 24, 2025

@Axelcureno Milo regressions are covered and

  1. I see figma mentioning following
    Name Body/Sans/Sans XS
    Font Adobe Clean
    Weight 400
    Style italic
    Size 12px
    Line height 18px
    Color: #464646
image

In the authored card - can make it Italic but other properties are not matched:
https://main--mas--adobecom.hlx.page/studio.html?milolibs=MWPW-166012--milo--adobecom#path=drafts
image
image

  1. Plz resolve conflicts at libs/deps/mas/merch-card.js

fyi @afmicka

Copy link
Contributor

Reminder to set the Ready for Stage label - to queue this to get merged to stage & production.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

@Axelcureno Axelcureno requested a review from Roycethan January 27, 2025 20:08
@Roycethan Roycethan added verified PR has been E2E tested by a reviewer commerce Ready for Stage labels Jan 27, 2025
@milo-pr-merge
Copy link
Contributor

milo-pr-merge bot commented Jan 28, 2025

Skipped 3520: "MWPW-166012: [CCD - Suggested Cards] Enable ABM text under price" due to file "libs/deps/mas/mas.js" overlap. Merging will be attempted in the next batch

@Roycethan Roycethan added the high priority Why is this a high priority? Blocker? Critical? Dependency? label Jan 29, 2025
@milo-pr-merge milo-pr-merge bot merged commit 2082fe4 into stage Jan 29, 2025
19 checks passed
@milo-pr-merge milo-pr-merge bot deleted the MWPW-166012 branch January 29, 2025 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
commerce high priority Why is this a high priority? Blocker? Critical? Dependency? Ready for Stage verified PR has been E2E tested by a reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants