-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MWPW-166012: [CCD - Suggested Cards] Enable ABM text under price #3520
Conversation
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
|
libs/deps/mas/mas.js
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
libs/deps/mas/merch-card.js
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
libs/features/mas/dist/mas.js
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #3520 +/- ##
=======================================
Coverage 96.48% 96.48%
=======================================
Files 260 260
Lines 60808 60812 +4
=======================================
+ Hits 58670 58675 +5
+ Misses 2138 2137 -1 ☔ View full report in Codecov by Sentry. |
@Axelcureno Milo regressions are covered and
In the authored card - can make it Italic but other properties are not matched:
fyi @afmicka |
Reminder to set the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
Skipped 3520: "MWPW-166012: [CCD - Suggested Cards] Enable ABM text under price" due to file "libs/deps/mas/mas.js" overlap. Merging will be attempted in the next batch |
Allows authors to include the legend "Annual, paid monthly" next to the price in CCD suggested cards as part of a legal requirement.
Resolves: MWPW-166012
Mas link: https://main--mas--adobecom.hlx.page/studio.html?milolibs=MWPW-166012--milo--adobecom#path=drafts
Test URLs: